Fix the diffing logic in FlowerDiffCallback

android / views-widgets-samples

Multiple samples showing the best practices in views-widgets on Android.

Apache License 2.0

5.03k stars 3.01k forks source link

Fix the diffing logic in FlowerDiffCallback #237

Open nima-ahmadi opened 2 years ago

nima-ahmadi commented 2 years ago

According to the DiffUtil.ItemCallback documentation , and as the names suggest, areItemsTheSame should be checking if the IDs are the same and areContentsTheSame should be checking if the contents are the same.

nima-ahmadi commented 2 years ago

@nfischer 👋 Hi, sorry I wasn't sure who to tag to get a review on this (saw your review on another PR)

nima-ahmadi commented 2 years ago

@MagicalMeghan 👋 Hi, any thoughts?