android / views-widgets-samples

Multiple samples showing the best practices in views-widgets on Android.
Apache License 2.0
5.04k stars 3.01k forks source link

Fix scroll up motion on header #80

Open codingjeremy opened 4 years ago

codingjeremy commented 4 years ago

Issue by mwajeeh Friday Jul 26, 2019 at 12:01 GMT Originally opened as https://github.com/android/android-ConstraintLayoutExamples/pull/93


Removed useless swipe listener on header which was eating touch and causing parent motion layout to not scroll up if you swipe up in header area.


mwajeeh included the following code: https://github.com/android/android-ConstraintLayoutExamples/pull/93/commits

codingjeremy commented 4 years ago

Comment by googlebot Friday Jul 26, 2019 at 12:01 GMT


Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

codingjeremy commented 4 years ago

Comment by mwajeeh Friday Jul 26, 2019 at 12:03 GMT


I signed it!

codingjeremy commented 4 years ago

Comment by googlebot Friday Jul 26, 2019 at 12:03 GMT


CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

InsaneDoggo commented 4 years ago

Why it still isn't merged into master?