search

android10 / Android-CleanArchitecture-Kotlin

This is a movies sample app in Kotlin, which is part of a serie of blog posts I have written about architecting android application using different approaches.
https://fernandocejas.com/2018/05/07/architecting-android-reloaded/
4.68k stars 928 forks source link

Apply official Kotlin code style #110

Closed android10 closed 3 years ago

android10 commented 3 years ago

Why?

The current style was obsolete and based on Java.

How?

By using the official migration guide: https://kotlinlang.org/docs/code-style-migration-guide.html#in-maven

android10 commented 3 years ago

@ZhuSniffsTheRose inspired by your changeset, here I followed up the migration guide for the official kotlin style. Will definitely appreciate if you have a few minutes and check it out. Than you very much!

codecov[bot] commented 3 years ago

Codecov Report

Merging #110 (33aa468) into main (656a8b2) will increase coverage by 1.22%. The diff coverage is 15.04%.

@@             Coverage Diff              @@
##               main     #110      +/-   ##
============================================
+ Coverage     13.91%   15.13%   +1.22%     
  Complexity       16       16              
============================================
  Files            37       37              
  Lines           345      370      +25     
  Branches         48       48              
============================================
+ Hits             48       56       +8     
- Misses          294      311      +17     
  Partials          3        3
Impacted Files Coverage Δ Complexity Δ
...com/fernandocejas/sample/core/exception/Failure.kt 66.66% <0.00%> (ø) 0.00 <0.00> (ø)
...om/fernandocejas/sample/core/extension/Fragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...m/fernandocejas/sample/core/extension/Lifecycle.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/com/fernandocejas/sample/core/extension/View.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...com/fernandocejas/sample/core/functional/Either.kt 95.00% <ø> (ø) 5.00 <0.00> (ø)
...om/fernandocejas/sample/core/interactor/UseCase.kt 25.00% <0.00%> (-3.58%) 1.00 <0.00> (ø)
.../fernandocejas/sample/core/navigation/Navigator.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...nandocejas/sample/core/navigation/RouteActivity.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...fernandocejas/sample/core/platform/BaseActivity.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...fernandocejas/sample/core/platform/BaseFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 21 more
lrnrzg commented 3 years ago

@ZhuSniffsTheRose inspired by your changeset, here I followed up the migration guide for the official kotlin style. Will definitely appreciate if you have a few minutes and check it out. Than you very much!

👍🏻 Yeah, the new code style is the same as mine.