search

android10 / frodo

Android Library for Logging RxJava Observables and Subscribers.
1.48k stars 101 forks source link

Fixes NPE in jUnit tests #12

Closed dbacinski closed 8 years ago

dbacinski commented 8 years ago

@RxLog* annotations are not preserved in jUnit tests which cases NPE

Changed retention policy to RUNTIME.

android10 commented 8 years ago

Make sure you are using this code style: https://github.com/android10/java-code-styles

dbacinski commented 8 years ago

@android10 https://github.com/android10/java-code-styles fork is 25 commit behind Square version. Wouldn't it be better to use Square version?

android10 commented 8 years ago

@dbacinski I will update my checkstyle repo soon but for now for consistency let's use my version, otherwise there is gonna a lot of noise when reformatting. Thanks :smile:

android10 commented 8 years ago

@dbacinski by the way, can you squash all the commits into one? So we don't pollute git history :smile:

dbacinski commented 8 years ago

Done.

android10 commented 8 years ago

@dbacinski thanks so much for the contribution! :+1: