search

android10 / frodo

Android Library for Logging RxJava Observables and Subscribers.
1.48k stars 101 forks source link

Logging for methods returning Subscription #3

Closed Android-s14 closed 8 years ago

Android-s14 commented 8 years ago

Feature request if this is technically possible.

android10 commented 8 years ago

Could you elaborate more @Android-s14 ?

Android-s14 commented 8 years ago

My apologies for being unclear. Say we have a method:

Observable<String> changes();

I can just annotate it with @RxLogObservable and it works great.

Now I decide it's more convenient to subscribe to this observable inside the method and return Subscription (e.g., to add it to a CompositeSubscription right away):

Subscription changes();

I can always extract the observable creation part into it's own method and annotate it, but wouldn't it be convenient if I also could annotate methods returning Subscription?

android10 commented 8 years ago

I want to keep the library as simple as possible for now and fix issues people come up with. Even though that, this is something I will keep in mind for future versions. Thanks for the feedback.

farmazon3000 commented 8 years ago

I will keep in mind for future version

Then why did you close this issue instead of changing it to "feature request" type?