oceanjules
commented
3 weeks ago You pasted the documentation that describes the 2 necessary steps: "This change can be overridden by calling both
- MediaSource.Factory.experimentalParseSubtitlesDuringExtraction(false) and
- TextRenderer.experimentalSetLegacyDecodingEnabled(true)."
In your project, you have:
fun buildLiveMediaSource(dataSource: PlayerDataSource,
sourceUrl: String?,
type: @C.ContentType Int,
metadata: MediaItemTag?
): MediaSource? {
val factory: MediaSource.Factory = when (type) {
C.CONTENT_TYPE_SS -> dataSource.liveSsMediaSourceFactory
C.CONTENT_TYPE_DASH -> dataSource.liveDashMediaSourceFactory
C.CONTENT_TYPE_HLS -> dataSource.liveHlsMediaSourceFactory
C.CONTENT_TYPE_OTHER, C.CONTENT_TYPE_RTSP -> throw ResolverException("Unsupported type: $type")
else -> throw ResolverException("Unsupported type: $type")
}
return factory.createMediaSource(So you know where you are creating your MediaSource.Factory
You also have
private fun initPlayer(playOnReady: Boolean) {
Logd(TAG, "initPlayer() called with: playOnReady = [$playOnReady]")
exoPlayer = ExoPlayer.Builder(context, renderFactory)
.setTrackSelector(trackSelector)
.setLoadControl(loadController)
.setUsePlatformDiagnostics(false)
.build()Which means you have renderFactory which you can customise with the second call.
If you were using DefaultMediaSourceFactory, you could do both like:
ExoPlayer.Builder(context)
.setRenderersFactory(
new DefaultRenderersFactory(context) {
@Override
protected void buildTextRenderers(
Context context,
TextOutput output,
Looper outputLooper,
@ExtensionRendererMode int extensionRendererMode,
ArrayList<Renderer> out) {
super.buildTextRenderers(context, output, outputLooper, extensionRendererMode, out);
((TextRenderer) Iterables.getLast(out))
.experimentalSetLegacyDecodingEnabled(!parseSubtitlesDuringExtraction);
}
})
.setMediaSourceFactory(
new DefaultMediaSourceFactory(context)
.experimentalParseSubtitlesDuringExtraction(parseSubtitlesDuringExtraction))
.build();
icbaker
Version
Media3 1.4.0
More version details
No response
Devices that reproduce the issue
Android 9, Android 14
Devices that do not reproduce the issue
none
Reproducible in the demo app?
Yes
Reproduction steps
Media3 1.3.1 works fine, BTW.
The error seems complaining about "Legacy decoding is disabled". I checked the release notes of 1.4,0, which has some text about legacy content (quoted below), so this exception is intended? If that's the case, please help on how to work around it. Unfortunately I can't find further documentation on that.
"Change default subtitle parsing behavior so it happens during extraction instead of during rendering (see ExoPlayer's architecture diagram for the difference between extraction and rendering). This change can be overridden by calling both MediaSource.Factory.experimentalParseSubtitlesDuringExtraction(false) and TextRenderer.experimentalSetLegacyDecodingEnabled(true). See the docs on customization for how to plumb these components into an ExoPlayer instance. These methods (and all support for legacy subtitle decoding) will be removed in a future release. Apps with custom SubtitleDecoder implementations need to update them to implement SubtitleParser instead (and SubtitleParser.Factory instead of SubtitleDecoderFactory)"
Expected result
should continue playing and show caption
Actual result
got an exception:
Media
any youtube video from within the NewPipeX app.
Bug Report
adb bugreportto android-media-github@google.com after filing this issue.