search

androidx / media

Jetpack Media3 support libraries for media use cases, including ExoPlayer, an extensible media player for Android
https://developer.android.com/media/media3
Apache License 2.0
1.71k stars 408 forks source link

Details about internal issue: b/63092960 #1697

Open Tolriq opened 2 months ago

Tolriq commented 2 months ago

Some users contacted me because they can't play some opus files in m4a container.

After some debugging it's because Media3 incorrectly think they are DRM protected and the code path that is supposed to clear the drmInitData is commented out with // TODO: Uncomment when [Internal: b/63092960] is fixed.

Since that bug is private can we have some details about the bug and the potential impact of reverting the workaround for it in media3 in a local fork?

https://github.com/androidx/media/blob/main/libraries/extractor/src/main/java/androidx/media3/extractor/mp4/BoxParser.java#L1154 https://github.com/androidx/media/blob/main/libraries/extractor/src/main/java/androidx/media3/extractor/mp4/BoxParser.java#L1771

marcbaechinger commented 2 months ago

Thanks for your report.

Can you provide us with a sample of such media that causes the issue so we can repro?

Re-assigning to @rohitjoins for looking into this extractor issue which it seems to be.

Tolriq commented 2 months ago

@marcbaechinger I've sent the file to the usual email + issue title, but the user admitted it's pirated content found on telegram so it's highly possible there was DRM badly removed and not worth something from your side.

Just wanted some details about that private issue if possible to know the risk to workaround on my side.