andromedaprotocol / ado-database

Repository for submission and review of Andromeda Digital Objects
0 stars 4 forks source link

ADO Idea Proposal - NFT Staking #8

Open oneShot0430 opened 3 months ago

oneShot0430 commented 3 months ago

Contact Information -Name: Richard Thomas -Discord: konta5497 -Email Address: healer0991@gmail.com

ADO Summary - What is the goal of this ADO and how does it function? The aim of this ADO is to offer a smart contract that enables users to stake, unstake, and claim their NFTs, along with any accrued rewards, after the unbonding period has elapsed.

Does it need to work with another ADO or is it standalone? Also, does it implement any modules? This ADO is designed to function independently and does not rely on other ADOs or implement any modules.

Are you planning to build this ADO yourself, or by the Andromeda team (myself)

Credits/Associations - Is this ADO based upon a previous project or ADO or in partnership with any other groups or developers? If so, please list here and provide a link if possible. This ADO is an original project and is not based on or affiliated with any previous projects, ADOs, groups, or developers.

Can you provide any docs/articles/research that explains the main idea of the ADO and how/why it is used. For more information on the concept and utility of the ADO, please refer to the following resources: https://www.andromedaprotocol.io/aos-hackerboard https://www.coinbase.com/en-ca/learn/advanced-trading/what-is-nft-staking-and-how-does-it-work https://stackbrowser.com/blog/staking-nfts

ADO Flow Breakdown - Please list and provide descriptions of each step in the ADO flow sequence (show us how to work with the ADO and associated workflow, visuals are great here):

Considerations/Concerns - What factors should be considered to mitigate risk of misuse, abuse, or other unintended scenarios, if any?

Possible Next Iterations/Future Work - How can this ADO be further enhanced?

Any Dependencies or Third Party Integrations? (Ex. Will this ADO need to work with anything off chain, a different app, etc?): This ADO does not require any dependencies or third-party integrations.

kevincolahan commented 3 months ago

Thank you for submission. This is under review currently. Will report back soon :)

joemonem commented 3 months ago

Looks good to me, looking forward to reviewing the implementation!

oneShot0430 commented 3 months ago

Sounds good, I will complete it in several days

oneShot0430 commented 2 months ago

I found an issue for enhancement in andromeda core while working on the hackerboard. Mind reviewing that if you don't mind?

https://github.com/andromedaprotocol/andromeda-core/issues/500

I think this might be pretty important for hackerboard submissions as it is also somewhat related to the template function

joemonem commented 2 months ago

I'll look into it and get back to you, thanks for the feedback.

mdjakovic0920 commented 2 months ago

I also think it is important thing for Hackerborad ADO development - https://github.com/andromedaprotocol/andromeda-core/issues/500 In development I used andromeda_std::error::ContractError as return type of customized ADO, but it limits the utility of various kinds of error at ADO development outside of Core framework.

kevincolahan commented 2 months ago

I also think it is important thing for Hackerborad ADO development - andromedaprotocol/andromeda-core#500 In development I used andromeda_std::error::ContractError as return type of customized ADO, but it limits the utility of various kinds of error at ADO development outside of Core framework.

@daniel-wehbe - can we make sure this is part of any of the ADO submission or build out details if it doesn't exist currently?

kevincolahan commented 2 months ago

@oneShot0430 - any other issues you ran into? Hope you had a good weekend!

oneShot0430 commented 2 months ago

Thank you for your asking, @kevincolahan , I had a nice weekend, Heop you also had a weekend. I will let you know if I have any issue furthermore.