ref: Rates Adjustments

[joemonem]

Motivation

Closes #522 and #523

Implementation

Stopped concatenating CONTRACT_NAME to msg.as_ref() The previous Rates variant was causing errors during deserialization, so I changed its structure in accordance to the rest of the variants. It is now

Rates {action: String}

instead of

RatesQuery(::andromeda_std::ado_base::rates::RatesQueryMessage)

Added an AllRates query which returns a vector of (action,Rate) tuples

Testing

Removed contract name from actions. Rates and AllRates query in marketplace integration test.

Version Changes

Bumped affected contracts by 0.0.1

Summary by CodeRabbit

Summary by CodeRabbit

• New Features

  • Incremented version numbers for several packages, indicating minor updates and improvements.
  • Added new querying capabilities in the marketplace, allowing users to retrieve rate and version information dynamically.

• Bug Fixes

  • Simplified action processing logic in multiple contracts, enhancing clarity and potentially fixing related issues.

• Tests

  • Updated test cases to utilize more general naming conventions for actions, improving consistency and readability.

[coderabbitai[bot]]

Walkthrough

This update simplifies action name handling for rates in the Andromeda contracts by removing the dependency on get_action_name and directly converting messages to strings. This change aligns with the requirement to use only the message name for rates, similar to permissioning, enhancing code clarity and maintainability.

Changes

Files	Change Summary
contracts/data-storage/andromeda-primitive/..., contracts/fungible-tokens/andromeda-cw20/..., contracts/non-fungible-tokens/andromeda-auction/..., contracts/non-fungible-tokens/andromeda-cw721/..., contracts/non-fungible-tokens/andromeda-marketplace/...	Version updates; streamlined action handling in handle_execute by removing get_action_name dependency; adjustments to tests for clarity.
packages/std/src/common/mod.rs	Removed call_action module from public exports, focusing on core functionalities.
tests-integration/tests/...	Adjusted string parameters in various tests to simplify naming conventions without changing logic.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Auction
    participant Rates

    User->>Auction: Execute action
    Auction->>Rates: Set rates with action name
    Rates-->>Auction: Confirm rates set
    Auction-->>User: Return result

Assessment against linked issues

Objective	Addressed	Explanation
Rates action name should not include contract address (Issue #522)	✅
Simplify rate setting logic	✅
Ensure consistency in action retrieval for rates	✅

Poem

🐇 In fields of code where rabbits play,
Simplified paths lead us on our way.
With names so clear, no need for fuss,
We leap with joy, in code we trust!
New rates set, with hops so spry,
Let's celebrate, oh my, oh my! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.