fix: Splitter & Conditional Splitter LockTime

[joemonem]

Motivation

Closes #544

Implementation

Was comparing the lock time's timestamp with a representation of one day and one year in seconds. Now it's being compared with the current time in addition to one day and one year in milliseconds.

Made Conditional Splitter's lock the same as the one in Splitter.

Testing

test_different_lock_times for both splitter contracts. Tests for too short, long and correct lock times using both Expiry::AtTime and Expirty::FromNow.

Version Changes

Bumped splitter from 2.0.0 to 2.1.0 and conditional splitter from 1.1.0 to 1.2.0

Summary by CodeRabbit

• New Features

  • Enhanced handling of expiration times in the Conditional Splitter contract.
  • Added new test cases for various lock time scenarios.
  • Introduced a new error variant for invalid expiration times.

• Bug Fixes

  • Improved validation logic for lock times to ensure accuracy.
  • Fixed lock time calculation to enhance reliability.

• Documentation

  • Updated comments and documentation to reflect changes in time handling and contract logic.

• Refactor

  • Streamlined functions related to lock time management for clarity and efficiency.

[coderabbitai[bot]]

Walkthrough

The changes involve updates to the Cargo.toml file, including version constraints for dependencies and enhancements to the handling of lock times in multiple contracts. The lock_time parameter has been standardized to utilize the Expiry type, improving clarity and type safety. Additionally, error handling has been refined with the introduction of a new error variant related to invalid expiration times.

Changes

Files	Change Summary
Cargo.toml	Updated dependency versions and changed cw-asset version specification to an exact constraint.
contracts/finance/.../contract.rs	Modified time constants to milliseconds, updated lock time initialization, and streamlined validation logic.
contracts/finance/.../mock.rs	Changed lock_time type from Option<u64> to Option<Expiry>.
contracts/finance/.../testing/tests.rs	Updated lock_time handling to use Expiry type and added new test cases for lock time scenarios.
packages/andromeda-finance/src/conditional_splitter.rs	Changed lock_time in ConditionalSplitter to a required field and updated InstantiateMsg accordingly.
packages/std/src/error.rs	Introduced a new error variant InvalidExpirationTime for improved error handling related to expiration.

Assessment against linked issues

Objective	Addressed	Explanation
Splitter lock time handling issues (Issue #544)	✅
Conditional splitter lock time type consistency (Issue #544)	✅

🐰 "In the meadow, we hop with glee,
New locks and times, oh what a spree!
With Expiry now, our paths are clear,
No more errors, let’s all cheer!
Hops and jumps, we’ll dance tonight,
Thanks to the changes, everything’s right!" 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.