Unit tests for download-file.js

andrscrrn / pizza-guy

If you already have a big list of urls of files that you want to download but you don't know how, this is your module.

MIT License

7 stars 3 forks source link

Unit tests for download-file.js #38

Open andrscrrn opened 8 years ago

andrscrrn commented 8 years ago

We should create robust tests for this module since it is the most important part of the module itself.

baldore commented 8 years ago

I'm gonna keep working on this, since it's more important than the pizzaGuy module itself and we don't need to fix the singleton problem. Things that need to be added:

[ ] Add redirection tests.
[ ] Add error tests.
[ ] Add checksum to see that the file was downloaded correctly.

andrscrrn commented 8 years ago

@baldore For the last item, it would be wise to start serving files locally knowing their checksum hashes, so we can test that without even relying on external sites (the current demo is using images hosted outside our control).

baldore commented 8 years ago

Yeah, we'll use the fixtures folder for it. Good catch :)