andruby / chef-crypto-coin

Chef cookbook to help compile bitcoin based crypto coins
MIT License
7 stars 13 forks source link

Extending LWRP #5

Open TheSerapher opened 10 years ago

TheSerapher commented 10 years ago

Excellent work on your Cookbook! It works indeed out of the box and I have successfully installed Darkcoin and Litecoin with it to test it out.

Now here some ideas that may expand this cookbook further. I may do some of these if this cookbook is still maintained.

Custom Coin Config

Instead of passing a predefined hash to the configuration file, allow a user to pass a array of hashes and further define the configuration. I am suggesting this since I had no way to create a testnet only configuration out of the box.

Change startup behavior

Instead of forcing upstart to it, allow a user to supply a custom init script or template to run a system specific startup process. This would help to spread this cookbook into other systems than Ubuntu (since Debian works just as well).

Do not link the source compiled binary

Instead of linking the compiled binary into the home folder, I would rather copy it entirely. Not sure if that's necessary but having the actual used binary linked against the one on the source tree, which could be upgraded by changing the Git checkout and triggering a new compile, seems unsafe.

TheSerapher commented 10 years ago

One idea for the startup change, maybe use a cookbook like runit that's supported under different platforms? Would allow adding the service to any other distribution that's supported by the upstream runit cookbook.

andruby commented 10 years ago

Hi @TheSerapher,

Thanks for the great suggestions. I agree with all of them. I haven't had much time to keep up with crypto currencies, but I will take the time to review any pull requests. And you're always welcome to fork :)

TheSerapher commented 10 years ago

No problem!

I was also wondering if we could use the Ark cookbook which combines a lot of the download, extract, install procedure. And instead of using the Git resource, we'd link against the tagged release for a coin.

Granted, it would require coins to properly use tags but IMHO that's a must if if want to take a coin seriously.

These are all generic suggestions that wouldn't only apply to the coins itself. So not being up to date with what's going on shouldn't be a big deal ;-) I can at least confirm that I was able to compile and install the latest tags available for Darkcoin. So others will probably work fine too.

Here another idea: don't use a all-in-one LWRP. That way users can decide what they wish to do. Maybe split it up into download/compile, install and configure. And one LWRP calle service to do all the steps if one decides to do so.

Just some more ideas.