search

andrusha / middleman-cloudfront

An Amazon CloudFront extension for middleman which allows you to invalidate CloudFront CDN cache
MIT License
58 stars 29 forks source link

Middleman v4.0 support #18

Closed bb-generation closed 8 years ago

bb-generation commented 9 years ago

Middleman is currently on its way to release verison 4.0. Unfortunately, middleman-cloudfront still has a dependency which restricts versions > 3.

You can find recent middleman alpha releases here: https://rubygems.org/gems/middleman-core (4.0.0.alpha.6 is the most recent one as of this writing)

I would really appreciate it, if this very helpful gem would introduce support for version 4.0

manuelmeurer commented 9 years ago

Unfortunately I won't have time to work on it. If you, or someone else, could do the first step and find out what changed in Middleman 4.0 and needs to be fixed for middleman-cloudfront to work, that would be very helpful!

rosskevin commented 8 years ago

@manuelmeurer I've done the conversion to middleman 4 - tests pass - though I have not yet used it in my site (which I will do over the next couple of days).

https://github.com/rosskevin/middleman-cloudfront/tree/middleman-4

The code is different enough that I would recommend you create a v3-maintenance branch before merging my PR.

rosskevin commented 8 years ago

PR is good to merge and release as a 4.x only compatible version