search

andrusha / middleman-cloudfront

An Amazon CloudFront extension for middleman which allows you to invalidate CloudFront CDN cache
MIT License
58 stars 29 forks source link

Change dependency to fog-aws instead of fog #24

Closed tmaier closed 1 year ago

tmaier commented 8 years ago

Get rid of unnecessary dependencies

untested™

andrusha commented 8 years ago

Looks like it breaks this require clause https://github.com/andrusha/middleman-cloudfront/blob/master/lib/middleman-cloudfront/commands.rb#L3

rosskevin commented 8 years ago

Please close this one, #23 does this and updates dependencies.

tmaier commented 8 years ago

Hi @rosskevin,

I really appreciate your work on #23. Getting to a version which supports middleman 4 is great. When I created my pull requests I was not aware that your pull requests also includes other changes, next to the upgrade to middleman 4.

However, I am also in favor of having small pull request which do one thing, so that their changes are better foreseeable.

Besides this, #23 will also lead to a major release, as the support for middleman 3 will be dropped. I don't see how this particular change is related to middleman 4 and why it should not be possible to get this improvement into a new minor release which is still compatible to middleman 3.

Best,

Tobias

tmaier commented 8 years ago

@andrusha, I updated the branch with the mentioned change

andrusha commented 8 years ago

@tmaier fair enough, have you tried it manually on some sample site?