andruzzzhka / BeatSaberMultiplayer

MIT License
152 stars 39 forks source link

Some avatars will render with the wrong height for other players #167

Open HugKitten opened 4 years ago

HugKitten commented 4 years ago

Desktop (please complete the following information):

Describe the bug Some avatars (I was using the "Ooka Miko 2nd Form" avatar and he was using the "Meika Mikoto" avatar) will show properly for the person wearing the avatar, but will display the avatar without the adjusted size to other players. I noticed this when me and my friend and we couldn't see each other correctly. When I pat his head, he would see my hands in his face. When he tries to head pat me, his hands are always below my avatar's height, but wouldn't be in my face. I'm about 5"7 and hes 5"11. Also his avatar has a greater size difference than his height which probably makes it more noticeable on his end. Once we switched to another avatar "Ooka Miko" we found that the height of the avatar was rendered correctly for each other and I saw on his screen what he saw on my screen. (We have the camera plus mod)

Steps to reproduce Steps to reproduce the behavior:

  1. Set up the mod with the mod installer on the read me. (and all its required dependencies and such) Use BSIPA version 4.0.3.
  2. Pick one of the broken avatars ("Ooka Miko 2nd Form" or "Meika Mikoto").
  3. Enable the option to resize the avatar to your height or arm length.
  4. Go into a room with people and ask them where your avatar's head is.
  5. Notice that their hands are usually below your actual avatar's height.

Expected behavior That avatars would display with the correct height

Avatars avatars.zip

HugKitten commented 4 years ago

I think the issue may be fixed by having the multiplayer mod send avatar scale and use that for the size instead of the way it's currently doing it. It'd also ensure that players looked the same to each other no matter what setting they have on the avatar mod. That being said, I don't really know a whole lot about unity or how it handles VR.