andry-tino / Rosetta

Toolset for migrating your codebase from C# to TypeScript
http://antino-enlad.cloudapp.net:8080/job/Rosetta/
GNU General Public License v3.0
24 stars 9 forks source link

Type definitions for setters are missing return type #25

Closed guidoren closed 7 years ago

guidoren commented 7 years ago

Setters are emitted as:

set_example(value : Example);

If implicit allow any is enabled that will compile fine; otherwise it is a compile error. Instead, this should be emitted:

set_example(value : Example): void;
andry-tino commented 7 years ago

Will always emit the return type in order to fix this. \

Scope

This feature will only be available in the ScriptSharp definition generator as we want to introduce a flag in the normal transpiler for emitting void and any explicitely or not (same as implicit allow any)