andryou / scriptsafe

a browser extension to bring security and privacy to chrome, firefox, and opera
https://www.andryou.com/scriptsafe
509 stars 79 forks source link

[Vivaldi] Inconsistent icon changes after switching tabs via keyboard or automatically #388

Open chocmake opened 5 years ago

chocmake commented 5 years ago

After switching tabs using keyboard commands (eg: Ctrl+T, Ctrl+W) or automatically after a tab has been opened/closed the ScriptSafe icon changes its icon incorrectly.

Steps to reproduce:

  1. Open a web page and temporarily allow all scripts (extension switches to blue icon)
  2. Open a new tab (switches to green tick icon)
  3. Open another new tab (same green tick icon)
  4. Close the tab to return to the previous new tab (switches to red 'blocked' icon)
  5. Close the other new tab to return to the original web page (icon stays on red icon when it should be the blue 'temporary' icon, also no icon badge appears).

To return to the correct icon and icon badge for the initial web page a different tab has to be selected with the mouse then the previous tab re-selected.

From what I can tell this doesn't affect selecting tabs via the mouse, however this does affect any time the browser returns the user to a previous tab automatically (eg: closing a tab). I also haven't found this affects the icon if the tabs were switched via the tab switcher UI (Ctrl+Tab).

Edit: as a sidenote I'm not sure what the correct icon should be for blank tabs. In my Chromium install it's the red 'blocked' icon.