andsens / bootstrap-vz

Bootstrap Debian images for virtualized environments
http://bootstrap-vz.readthedocs.io/
Other
263 stars 143 forks source link

add ability to use profile for ec2 provider #423

Closed drts01 closed 6 years ago

drts01 commented 6 years ago

Addresses Issue #420

andsens commented 6 years ago

This cannot be merged as is right now, because it removes support for access/secret token. It would break a lot of peoples manifests. You will also need to document the ability to use the profile parameter in the EC2 docs.
Linting also fails right now:

bootstrapvz/providers/ec2/tasks/connection.py:52:13: E123 closing bracket does not match indentation of opening bracket's line
bootstrapvz/providers/ec2/tasks/connection.py:59:21: E122 continuation line missing indentation or outdented

:-(

drts01 commented 6 years ago

I have not removed the ability to read in access/secret token, https://github.com/andsens/bootstrap-vz/pull/423/files#diff-df81a97bd0bc86ad6a46a564ff3dd58dR77. It takes precedence over any other creds.

drts01 commented 6 years ago

corrected the styling and updated docs.

andsens commented 6 years ago

You're right. I misread the code. Looks good! Merging...