andsens / bootstrap-vz

Bootstrap Debian images for virtualized environments
http://bootstrap-vz.readthedocs.io/
Other
263 stars 143 forks source link

Add Docker specific settings #458

Closed drts01 closed 6 years ago

drts01 commented 6 years ago

From https://github.com/moby/moby/blob/e2e5d4bc9da5ba17bb2822909611f8300fdd80f0/contrib/mkimage/debootstrap,

andsens commented 6 years ago

Nice job, especially with the references. I wouldn't add tasks from other plugins though (CreateDpkgCfg). I think it'd be much better to simply add a proper manifest example that causes that task to be added.

drts01 commented 6 years ago

Yeah, using another plugin task like that felt dirty. So, I added at as a requirement. I also updated the docs and included two new manifest files for Docker.

andsens commented 6 years ago

The manifests & docs look great! Instead of using makedirs though, you should probably just move CreatDpkgCfg to common/ so that both plugins may add and depend on it.
After all that's partially why common/ exists :-)
The tasklist is a set, so there is no harm in adding a task twice.

drts01 commented 6 years ago

updated :)

andsens commented 6 years ago

Perfect! Merging...