Pylint code clean up - Githubissues

andsens / bootstrap-vz

Bootstrap Debian images for virtualized environments

http://bootstrap-vz.readthedocs.io/

Other

263 stars 145 forks source link

Pylint code clean up #471

Closed drts01 closed 6 years ago

drts01 commented 6 years ago

enable more pylint tests
also fixes a cross-plugin dependency which was broken from a previous commit that moved a task to commons (prebootstrapped was calling task in dpkg)

andsens commented 6 years ago

Holy macaroni! That is impressive! I have checked the diff but couldn't find the fix you are talking about, care to elaborate that one?

drts01 commented 6 years ago

I had actually forgot myself and need to go through and find the commit myself. Pylint E1101(no-member) caught it. The prebootstrapped plugin was calling task in the dpkg plugin which was moved to the commons because I was trying to do the same cross plugin thing. :)

https://github.com/andsens/bootstrap-vz/pull/471/commits/b180f66ef022631ba46849158940829dc0896db6#diff-4536f249c1c9a9eae6c99cbd62693afc

andsens commented 6 years ago

Before merging this, could you add the pytlint check to tox.ini and make sure travis-ci runs the checks?
Also: Doesn't this replace flake8? If so, that dependency should probably be removed.

drts01 commented 6 years ago

It is running in tox/travis now. https://travis-ci.org/andsens/bootstrap-vz/builds/374071447#L448, https://github.com/andsens/bootstrap-vz/blob/master/tox.ini#L11. :)

I figured I would leave flake8 there until the todo's were done. https://github.com/andsens/bootstrap-vz/pull/471/files#diff-7960115f72225be4a82e33b5a7857f5aL41 But if you prefer I can remove it.

andsens commented 6 years ago

Sorry about the delay, should've merged this long ago. Ah well, better late than never :-)