Added pip3 plugin - Githubissues

andsens / bootstrap-vz

Bootstrap Debian images for virtualized environments

http://bootstrap-vz.readthedocs.io/

Other

263 stars 145 forks source link

Added pip3 plugin #481

Closed kirkhansen closed 6 years ago

kirkhansen commented 6 years ago

Copy pasted the pip_install command for a pip3_install Additionally:

Fixed the ENA download URL (Intel broke it with the latest release of the driver. see #402 )
Increased wait time for the snapshot to get created from 10 minutes to 30 minutes (this was taking around 15-20 minutes today for some reason).

andsens commented 6 years ago

Looks great!
Two topics of changes in one PR is normally discouraged, but since these are rather small changes it's fine. However the changes themselves do have to be in separate commits. The ec2 stuff has nothing to do with the pip stuff, I'd be grateful if you could split that up :-)

kirkhansen commented 6 years ago

@andsens Of course. Let me know if you'd like that changed from these three commits, or if you'd prefer additional PRs.

andsens commented 6 years ago

Nah, this is perfect :-)

Merging...