andsens / bootstrap-vz

Bootstrap Debian images for virtualized environments
http://bootstrap-vz.readthedocs.io/
Other
263 stars 145 forks source link

Add PNIN as a system manifest parameter. #485

Open john-pierce opened 6 years ago

john-pierce commented 6 years ago

Fixes: #349

Adds a new boolean parameter indicating weather to use PNIN or not to the system section of the manifest.

The default, False enables tasks for extlinux and grub to pass net.ifnames=0 biosdevnames=0 parameters to the kernel.

Previously for grub PNIN was disabled for stretch and later. This remains the default but setting system.pnin True will allow the behavior to be overridden. Extlinux had no prior special behavior, it now mirrors grub.

john-pierce commented 6 years ago

PR description edited to more accurately reflect the implementation, I changed the behavior before submitting without changing the commit message.

Edit: ~~The additional parameters have no effect on earlier releases are passed regardless.~~

The parameters are only passed to extlinux if pnin is False or unset and release is stretch or greater.

Feel free to edit the commit message while merging.