NVMe support for ec2 provider

john-pierce commented 6 years ago

Fixes: #452

Adds support for building on EC2 hosts that have NVMe EBS devices.

Introduces the DescribeInstances permission requirement for the calling role.

Changes the device naming logic on the host during build time.

The new target volume will be mounted with the highest available DeviceName in the BlockDeviceMapping object, taking care to avoid assignments that also are allocated at launch to ephemeral devices (C5d, I3, F1, and M5d currently).
The system device name will be identifed by the difference between the existing block devices prior to and after the AttachVolume call has finished. This does not address the race condition identified in #459.

andsens commented 6 years ago

Wow. Nice job on these PRs, they look really good. I have reviewed and merged the easiest one. I hope I can find the time this week to review this one and #485.

andsens commented 5 years ago

Hey John, thank you for the PR. I don't have the time or will to maintain this any longer, so I decided to archive the project.
While I trust your code to be of high quality I don't feel comfortable to merge it right before shutting the project down.

andsens / bootstrap-vz

NVMe support for ec2 provider #486