search

andsens / build-debian-cloud

This project has been superseeded by andsens/bootstrap-vz and is no longer maintained - Script to create Debian Squeeze & Wheezy Amazon Machine Images (AMIs) and Google Compute Engine images
Other
116 stars 43 forks source link

Fix image_commands and user_packages #120

Closed osallou closed 10 years ago

osallou commented 10 years ago

Hi, here are a few patches regarding image_commands and user_packages.

image_commands: various fixes to match updates on the base (volume, filesystem,...). It was not working anymore.

user_packages: fix the issue #119, installing the packages at system modification instead of debootstrap due to described issue. I also changed apt.py to use the debootstrap manifest mirror (or the default one). Indeed, it was set to a default debian mirror site, and may differ from bootstrap selected mirror. For user_packages download, it leaded to long downloads in my case versus my selected mirror (and different apt keys), or for final user it may not match the expected default mirror from the image creator.

Regarding user_packages I think you are rewriting it in python-WIP so you may need to adapt modifications in your branch.

andsens commented 10 years ago

You should split this PR up. Some of the changes are bugfixes while others change behavior. Normally you'd have one fix/enhancement per PR. This one is an all or nothing.

andsens commented 10 years ago

Also. Try verifying that you conform to most PEP8 guidelines by running find . -name '*.py' | /usr/bin/grep -v minify_json | xargs pep8 --ignore=E101,E221,E241,E501,W191. The WIP branch conforms fully to that spec.