search

andsens / homeshick

git dotfiles synchronizer written in bash
MIT License
2.11k stars 145 forks source link

Tests also have to observe HOMESHICK_DIR. #139

Closed oreinert closed 9 years ago

oreinert commented 9 years ago

This allows running detached tests (i.e., the test cases do not have to be co-located with the homeshick instance under test), like this: $ HOMESHICK_DIR=/usr/share/homeshick bats test/suites/

This PR is a follow-up to #138.

oreinert commented 9 years ago

It would be nice if this PR could also be promoted to testing fairly quickly.

andsens commented 9 years ago

Uuh, nice, will merge this tonight.

It would be nice if this PR could also be promoted to testing fairly quickly.

Agreed. I'll merge the current testing into master in a week I think, so far there have been no problems.

oreinert commented 9 years ago

Great!

andsens commented 9 years ago

Hmm, looking at this I'm beginning to think that we don't need any symlinks at all. We could just export $HOMESHICK_DIR with the parent path of $TESTDIR.

oreinert commented 9 years ago

If what you mean is export HOMESHICK_DIR=${HOMESHICK_DIR:-$(dirname $TESTDIR)}, then yes, in principle. But in many places it seems $HOMESICK/repos/homeshick is assumed to work, so some cleanup is needed for it to work properly. That could be my next PR. :-) (Or perhaps you'd like to do it yourself?)

oreinert commented 9 years ago

Use of symlinks removed - it was easier than I expected.

andsens commented 9 years ago

Aaaw yisss. Now that is a sexy PR - more code removed than added :-) Merging...

andsens commented 9 years ago

Update: I just merged in to master :-)

oreinert commented 9 years ago

Cool! Thanks for the update. Btw, yes, I agree that removing code is almost even more pleasing than writing it. :-)

On 02.05.2015, at 09:39, Anders Ingemann notifications@github.com wrote:

Update: I just merged in to master :-)

— Reply to this email directly or view it on GitHub.