search

andsens / homeshick

git dotfiles synchronizer written in bash
MIT License
2.11k stars 145 forks source link

Fix fish path resolution for paths with spaces #171

Closed herrbischoff closed 6 years ago

herrbischoff commented 6 years ago

It appears to be a fish issue (https://github.com/fish-shell/fish-shell/issues/3708), which is worked around by adding (string escape -- $argv) instead of $argv.

Fixes #170

andsens commented 6 years ago

Nice. Thank you for your work on debugging and fixing this! I would need you to direct the PR at the development branch though. I'll then FF it to testing and finally to master.
Also: If you have the time, could you add a regression test that reproduces this error? Right now there is only a single test for fish specifically: https://github.com/andsens/homeshick/blob/a92d067a6e6a40a9347f788d74e3226016552169/test/suites/cd.bats#L91-L100

It'd be great if we could make sure that this error doesn't reoccur.

herrbischoff commented 6 years ago

Oh, yes, of course. Sorry I skipped the contribution guidelines, they are pretty clear:

Work from and create pull requests on development, not master.

I'll see about the test but today I probably won't be able to do it, I'm halfway on my way out the door right now... :)