search

andsens / homeshick

git dotfiles synchronizer written in bash
MIT License
2.11k stars 146 forks source link

Add --git option to clone command #209

Closed iomartin closed 2 years ago

iomartin commented 2 years ago

When using the shorthand notation for the clone command (homeshick clone

/), homeshick converts this to a GitHub repo with the https protocol (https://github.com//\.git). This can be inconvenient if it is a private repo, as you then have to type your password. For such cases, using the git protocol might be preferred. This commit introduces a --git option that, when used, uses the Git protocol instead: git@github.com:\/\.git That option is ignored for other commands or full repo addresses.
andsens commented 2 years ago

Excellent contribution! I appreciate the completeness of your PR, with use-case description, tests, completion, help text, and more. However, the option itself is IMO only marginally useful compared to the additional code that is required (and will need to be maintained). I like to keep things very simple, for that reason I'll not be merging this.