Don't use git tags in pull

andsens / homeshick

git dotfiles synchronizer written in bash

MIT License

2.11k stars 145 forks source link

Don't use git tags in pull #226

Closed yut23 closed 2 months ago

yut23 commented 2 months ago

As seen in #225, this approach was more complicated than it needed to be and caused confusion for users.

yut23 commented 2 months ago

I added a test for a pre-initialized castle and silenced the rev-parse error. It currently goes through with the pull and runs symlink_new_files, but the git diff fails as @{1} doesn't exist. We could have it check for that case and list all the files in home/ instead, but that would mean more special cases.

andsens commented 2 months ago

Brilliant. Thank you for all the work Eric! I just noticed that I can't merge though, the PR is for master rather than development, could you quickly fix that? After that I'll run with it for a short week and make sure nothing is amiss and then merge it.