andsfonseca / dota2-rpc-client

Allows you to observe the status of your DotA 2 (Defense of the Ancients 2) match within the Discord, through the Rich Presence service. 🎮
https://andsfonseca.github.io/dota2-rpc-client/
MIT License
41 stars 8 forks source link

Persian Translation Submission #62

Closed wayofmani closed 1 month ago

wayofmani commented 1 month ago

Hello, or as we say in Persian :

"درود" (/doroud/)

I have a translation available at fa-ir.json file for Persian language.

I can assure you that all translations in the app are in common, modern Persian and they all are ok. but maybe you have some issues with translation for hero names cause I've did it but i didn't saw someone else translates hero names. Many Iranians have enjoyed Dota 1 (All-Stars/Warcraft 3) and Dota 2 in gaming cafes and clubs, and because of that they have their own called names for heroes those were inside the game from the 0 day and I've did translated those heroes in that way.

1. Localized

wayofmani commented 1 month ago

Persian is a RTL language, might be makes some issues...

andsfonseca commented 1 month ago

Hi @wayofmani, about your translation issues. I don't think it would be a problem to put your translation. For example, here in Brazil, new heroes like Mars and Primal Beast received names translated as "Marte" and "Fera Primal"), although almost no one I know speaks these names, I chose to leave the translation just for testing purposes and did some jokes also like changing the name Wraith King to Skeleton King when using the arcana (removed by the community a few versions ago). So I have no problem leaving your translation, in fact you have my full support for adding your version!

Regarding the fact that it is RTL, I will have to study the behavior, but I should be able to solve any problems (if any) from the next version, nothing to worry about ;)

andsfonseca commented 1 month ago

By the way, you can test your translation by placing your json inside the dota2-rpc files and changing the default language manually.

If you want to try it...

wayofmani commented 1 month ago

Hi @wayofmani, about your translation issues. I don't think it would be a problem to put your translation. For example, here in Brazil, new heroes like Mars and Primal Beast received names translated as "Marte" and "Fera Primal"), although almost no one I know speaks these names, I chose to leave the translation just for testing purposes and did some jokes also like changing the name Wraith King to Skeleton King when using the arcana (removed by the community a few versions ago). So I have no problem leaving your translation, in fact you have my full support for adding your version!

Regarding the fact that it is RTL, I will have to study the behavior, but I should be able to solve any problems (if any) from the next version, nothing to worry about ;)

That's nice to hear about, hope all things works well.