search

andulv / RSTabExplorer

RockSmith Tab Explorer
80 stars 18 forks source link

Note bends [via Reddit] #4

Open Jamedjo opened 10 years ago

Jamedjo commented 10 years ago

It really needs bend indicators for learning lead parts; it just seems to show the unbent note.

http://www.reddit.com/r/rocksmith/comments/24cd0u/rocksmith_tab_explorer_github/ch5zl57

andulv commented 10 years ago

I have added support for bended notes. It seems to work for the (few) cases I have tested with. But I will be surprised if is correct for all variations of bends that may exist.

Please report any bugs found, together with what the correct result should have been.

apelliciari commented 10 years ago

bends are not working on v0.0.4.0

taking an example: Queen - We are the champions (Lead), beat 30-31-32 http://i.imgur.com/8o08vh0.png

No bends in the sheet, but actually there are a lot of bends in there ( see http://youtu.be/lqX0SClIv-c?t=1m53s )

andulv commented 10 years ago

My comment was a bit unprecise. I just commited the code that supports bended notes. The new version with this feature was not yet released when I wrote the comment above.

But now Jamedjo has prepared v0.0.5.0, where this feature should be included. Please test and give feedback!

apelliciari commented 10 years ago

Hi andulv,

i've tried with 0.0.5.0, but no bends yet :(

see the screenshot, same song and beats above http://i.imgur.com/hOQmMiM.png

andulv commented 10 years ago

I have found the issue, and will probably get it fixed or find a workaround one of the next days.

It seems like AlphaTab (the component that we use to render the tablature) ignores bends where the bend starts immediately when the note is played. (Bend is at offset 0.0 from starttime of the note)

Bended notes that start out on the original note and then is bent after some time seems to render correctly.