search

andune / HomeSpawnPlus

Home/Spawn control plugin for Bukkit
GNU General Public License v3.0
13 stars 10 forks source link

Fixes an exploit which allowed the player to set a new home while a warmup was in progress #11

Open zhro opened 10 years ago

zhro commented 10 years ago

I used google translate for all for all of the english-to-language translations and the following website for english-to-brazilian, which I was unaware is different from regular Portuguese:

http://www.translation-guide.com/free_online_translators.php?from=English&to=Brazilian

Also; I'm not a fan of tabs. :(

andune commented 10 years ago

Yes, I hate the tabs myself. It's a leftover from Eclipse default settings which I didn't notice until I started browsing code on github much later. I've slowly been cleaning up my projects with it but hadn't done it to this codebase yet; I did it in 2.0 instead, which was supposed to come out a long time ago. :)

Feel free to submit your code without tabs, but if you feel the need to indent fix an entire file, please do that as a separate PR from any functionality changes or bug fixes. Since I'm touching much of the code for UUIDs anyway I may finally do this myself in the very near future.

re: translations, thanks. My general preference has been just to provide the English localization and trust translators to fill in the rest if they are so inspired. While I trust Google translate to get the general message across if you're communicating in a pinch in a foreign language, I don't trust it not to be humorously wrong without a native language speaker validating. Better, I think, just to show the English (which HSP gracefully falls back to if there is no localized message) until a native speaker for that localization gets annoyed enough to submit updated translations.