search

andune / HomeSpawnPlus

Home/Spawn control plugin for Bukkit
GNU General Public License v3.0
13 stars 10 forks source link

Spigot 1.9 getOnlinePlayers() #87

Closed seema84 closed 8 years ago

seema84 commented 8 years ago

[00:48:09 ERROR]: Error occurred while disabling HomeSpawnPlus v2.0-b610 (Is it up to date?) java.lang.NoSuchMethodError: org.bukkit.Server.getOnlinePlayers()[Lorg/bukkit/entity/Player; at com.andune.minecraft.hsp.shade.commonlib.server.bukkit.BukkitServer.getOnlinePlayers(BukkitServer.j ava:268) ~[?:?] at com.andune.minecraft.hsp.util.SpawnUtil.updateAllPlayerLocations(SpawnUtil.java:262) ~[?:?] at com.andune.minecraft.hsp.HomeSpawnPlus.onDisable(HomeSpawnPlus.java:100) ~[?:?] at com.andune.minecraft.hsp.HomeSpawnPlusBukkit.onDisable(HomeSpawnPlusBukkit.java:121) ~[?:?] at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:293) ~[spigot-1.9.jar:git-Spigot-3af46 05-ed8cef0] at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:364) [spigot-1.9.jar:gi t-Spigot-3af4605-ed8cef0] at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:424) [spigot-1.9.jar:g it-Spigot-3af4605-ed8cef0] at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:417) [spigot-1.9.jar: git-Spigot-3af4605-ed8cef0] at org.bukkit.craftbukkit.v1_9_R1.CraftServer.disablePlugins(CraftServer.java:340) [spigot-1.9.jar:git -Spigot-3af4605-ed8cef0] at net.minecraft.server.v1_9_R1.MinecraftServer.stop(MinecraftServer.java:454) [spigot-1.9.jar:git-Spi got-3af4605-ed8cef0] at net.minecraft.server.v1_9_R1.MinecraftServer.run(MinecraftServer.java:595) [spigot-1.9.jar:git-Spig ot-3af4605-ed8cef0] at java.lang.Thread.run(Unknown Source) [?:1.8.0_73]

sorifiend commented 8 years ago

Pull requests #88 - #90 should fix this, along side my pull requests 1 and 2 for https://github.com/andune/anduneCommonBukkitLib

@andune sorry about some of the tab formatting, i didn't realize until after i had submitted them

andune commented 8 years ago

merged sorifiend's changes. sorifiend, thank you for fixing and sending PRs. Latest build is on Jenkins, though I haven't tested at all. seema or sorifiend, can you download and confirm it fixes the issue?

sorifiend commented 8 years ago

Because anduneCommonBukkitLib wasn't building correctly one issue remains. I have added a PR there that should fix it all when HSP is compiled with the new version of anduneCommonBukkitLib.

Edit: This is an amazing plugin, thanks a lot for the hard work you have put into it. I plan to keep using it for a little while, so if anything else comes up I can probably patch it, although I doubt there will be any more issues.

sorifiend commented 8 years ago

The latest build from Jenkins seems to be working perfectly. This issue can now be closed.

seema84 commented 8 years ago

I can confirm that.