search

andune / HomeSpawnPlus

Home/Spawn control plugin for Bukkit
GNU General Public License v3.0
13 stars 10 forks source link

Updated HomeSpawnPlus to account for deprecated members in 1.7.2 #9

Closed zhro closed 10 years ago

zhro commented 10 years ago

Mostly consisted of updating old type ids to Materials, as well as a few other minor deprecated functions.

zhro commented 10 years ago

As I'm not prepared to move to HSP 2.0 just yet, I'm more than happy to help keep the 1.7 branch up to date. Since I've been using it for a very long time, know it's ins-and-outs, and have tweaked everything config-wise for my exact use-case, I'm reluctant to make a jump to a new version without some serious testing.

As you may recall from one of my bukkit feature requests, there are some quirks that are present in 1.7 that may not exist or behave differently in 2.0. It makes a lot more sense to me to ensure that 1.7 continues to be rock solid for as long as possible.

andune commented 10 years ago

Sorry, I didn't make the connection between the pull requests and the Bukkit conversation. That helps to understand the context, thanks.

Sadly, real life responsibilities pulled me away before I could make the final push to get 2.0 out the door, it really is a much better design and has several new features that I'd love to make available to HSP users. I always hold out hope that I will get a chance to do some heavier testing or sign up a few testers to shake out any final bugs and get it released, but until that day comes, 1.7 is pretty stable and I committed to not adding new features myself so as to not be maintaining two separate code bases.

Happy to have help with 1.7 and as changes are made, I'll check in with the 2.0 code base to be sure it's applied there as well so there are no regressions when people start testing with 2.0 to help the project make that jump.

zhro commented 10 years ago

I've made an additional commit to this branch to account for the erroneous change I made to the previously referenced expression. It appears as though this is reflected here in the same pull request and I do not need to submit a new one.

As I'm also not entirely sure what the protocol is here, you'll want to double-check what actually happens when you merge.