andweeb / Ki

⌘ Work in macOS like you work in vim <currently under construction>
MIT License
126 stars 13 forks source link

fix: fix toggle volume mute not working #16

Closed foolish-birdy closed 3 years ago

foolish-birdy commented 3 years ago

Add not before isMute to toggle volume mute not working

andweeb commented 3 years ago

Thanks for the PR @foolish-birdy! Sorry for the state of develop at the moment, it currently has a lot of backwards incompatible v2 changes that might not be merged into master for a while.

Would you like this change to be put in a patch release soon? If so, it might make more sense for me to revert develop to be in sync with master and create a separate v2 branch.

foolish-birdy commented 3 years ago

No worries. I fixed this in my source code directly. This PR is base on develop branch.

andweeb commented 3 years ago

Alrighty sounds good, thanks for the fix!