search

andy-5 / wslgit

Use Git installed in Bash on Windows/Windows Subsystem for Linux (WSL) from Windows and Visual Studio Code (VSCode)
MIT License
1.19k stars 59 forks source link

Install script 'mklink' command parameters should be quoted #110

Closed rfgamaral closed 4 years ago

rfgamaral commented 4 years ago

It seems the mklink calls should have the parameteres quoted, otherwise one gets this:

Make sure Fork.RI is executable in WSL...
OK.

Create 'git.exe' symlink...
The syntax of the command is incorrect.
OK.

Simply changing all mklink calls from this:

mklink %CMDDIR%\git.exe %CMDDIR%\wslgit.exe

To this:

mklink "%CMDDIR%\git.exe" "%CMDDIR%\wslgit.exe"

Seems to fix the issue.

I apologize for not being able to open a PR for this and speed up the process, sorry :(

andy-5 commented 4 years ago

Thank you for reporting the issue, and describing the solution. I've uploaded a new release with the fixed install script.