search

andy-portmen / country-flags

adds a toolbar button to browser address-bar displaying current physical location of visited website
https://webextension.org/listing/country-flags.html
Mozilla Public License 2.0
133 stars 35 forks source link

Localisation #11

Closed x10GitHub closed 6 years ago

x10GitHub commented 6 years ago

Very useful add-on! Have you thought of localising it?

andy-portmen commented 6 years ago

Most parts are now localizable! Please create a new locale JSON file and request a pull merge to see how it works. We can fix whatever is left then! https://github.com/andy-portmen/country-flags/tree/master/_locales/en

x10GitHub commented 6 years ago

The next challenge in localisation would be the translation of the country names. This could be important because many country names are completely different from those in English. I could help you with creating the localization structure (.json file) as you define it.

All the best!

andy-portmen commented 6 years ago

I added all the iso codes to the translation file. This way they can be translated with locales.

x10GitHub commented 6 years ago

There are two strings left unlocalisable: "description", in manifest.json "Save" button label, in index.html

andy-portmen commented 6 years ago

There are two strings left unlocalisable

Fixed! Thanks.