search

andy-portmen / country-flags

adds a toolbar button to browser address-bar displaying current physical location of visited website
https://webextension.org/listing/country-flags.html
Mozilla Public License 2.0
137 stars 35 forks source link

Optional Features Not Appearing #30

Closed Taurean75 closed 6 years ago

Taurean75 commented 6 years ago

Only default ones appear... default

options

I'm using Firefox 57 x64.

Taurean75 commented 6 years ago

Only 6 options appear. Is this intentional?

andy-portmen commented 6 years ago

No this is a WebExtension limitation. There is no workaround for it.

d4k0 commented 6 years ago

Hi, this add-on uses a submenu to circumvent this restriction. Here is its github repository:

https://github.com/M-Reimer/undoclosetab

I'm not sure if this is only possible with buttons, though. But maybe you can have a look at it :).

andy-portmen commented 6 years ago

@d4k0 nice!

We have it on the dev version screen shot 2017-11-17 at 11 44 11 am

@x10GitHub, @Termuellinator and @Djfe guys would you please update the locales

d4k0 commented 6 years ago

Very cool, thanks!

Taurean75 commented 6 years ago

Cool!

x10GitHub commented 6 years ago

It's quite cool! The webstore description should be updated too.

andy-portmen commented 6 years ago

@x10GitHub Thanks. The webstore description is updated.

Djfe commented 6 years ago

sry for hijacking, but I need some info for translating the commit from above: What do you mean by "Optimizing code to access minimum number of possible requests" Have you reduced the number of requests happening in the background? What do you mean by "accessing requests"?

EDIT: "Checking local IP before searching databases" -> whether the IP is in the local network, so no flag needs to be displayed? the DB is local, right? (do you mean checking against local ip?)

EDIT2: What are the "badges"? (Update 0.2.2)

andy-portmen commented 6 years ago

I am just too lazy to write proper changelogs! Go with these replacements. I'll update the "En" locale.

Optimizing code to access minimum number of possible requests

Reduces the total number of background requests for resolving country codes from IP addresses.

Checking local IP before searching databases

Do not call the country code resolution worker if an IP address in the local range.

Extension now refreshes all the badges upon start-up

Extension now requests country code resolution for all open tabs upon start-up

the DB is local, right?

Yes!

Djfe commented 6 years ago

I don't need proper changelogs ^^ (these are fine) But certain aspects weren't clear to me, which would've lead to a rough translation, if I hadn't asked. So thx for clearing that up :)

I'll send you a pull request ;)

d4k0 commented 6 years ago

I just received the update and this new feature is working just fine. The "problem" now is that ALL services are listed in the "Other services" menu and not just those that I selected in the settings. Is there a technical reason for that or is it just a bug?

Djfe commented 6 years ago

according to the changelog: intentional

Maybe the settings should indicate it somehow when more than 5 checkboxes are ticked. Or everything checked above 5 could at the top of the others menu.

andy-portmen commented 6 years ago

everything checked above 5 could at the top of the others menu.

This sound like a good idea. We will have this on the next release.