search

andy-portmen / country-flags

adds a toolbar button to browser address-bar displaying current physical location of visited website
https://webextension.org/listing/country-flags.html
Mozilla Public License 2.0
133 stars 35 forks source link

non translatable strings #32

Closed Djfe closed 6 years ago

Djfe commented 6 years ago

I found two strings that aren't translatable at the moment: "Don't Show in Address Bar" "Manage Extension..." "Country Flags & IP Whois" (hovertitle of the icon)

andy-portmen commented 6 years ago

"Don't Show in Address Bar" "Manage Extension..."

Chrome injects these context-menu items and they have your browser locale.

andy-portmen commented 6 years ago

"Country Flags & IP Whois" (hovertitle of the icon)

This is the actual name of this extension. Although it is possible to make it localize-able, I think this is not a good idea. It would be hard to find the extension later if the localized name is used.

Djfe commented 6 years ago

ok I'm using Firefox 59 btw. And Firefox uses the english locale instead of german for the first and second string, I mentioned. Might be a bug in Firefox, should I report it on bugzilla?

andy-portmen commented 6 years ago

I'm using Firefox 59 btw.

Nice!

I would say they will fix this soon!