andy-portmen / country-flags

adds a toolbar button to browser address-bar displaying current physical location of visited website
https://webextension.org/listing/country-flags.html
Mozilla Public License 2.0
133 stars 35 forks source link

Update german translation #34

Closed Djfe closed 6 years ago

Djfe commented 6 years ago

I updated the german translation. I'm not exactly sure where "optionsURL" appears, so I hope it was ok to translate it

Regards, Djfe

andy-portmen commented 6 years ago

I'm not exactly sure where "optionsURL" appears, so I hope it was ok to translate it

screen shot 2017-11-15 at 12 28 16 pm

Djfe commented 6 years ago

ups, I actually meant optionsTitle not URL thx, for merging :)

andy-portmen commented 6 years ago

That is the title of the options page. Opera does not support the embedded options page (like Firefox and Chrome) and hence it is opened in a browser tab.

Djfe commented 6 years ago

I guess, it's not so useful to translate that string at all in that case, right? (since it's a name)

andy-portmen commented 6 years ago

I would say translate the "Options page" part and leave the rest as " :: Country Flags & IP Whois"

Djfe commented 6 years ago

OptionsURL is already translated correctly. Should I fix OptionsTitle or are you going to do that?

andy-portmen commented 6 years ago

Please request a pull merge. Thanks