search

andy-portmen / native-client

Native Messaging component for Windows, Linux, and Mac OS that is written in NodeJS.
https://add0n.com/open-in.html
Mozilla Public License 2.0
727 stars 474 forks source link

One last step #27

Closed Inginn closed 7 years ago

Inginn commented 7 years ago

I always get the One last step window pop up, this was no issue for the first months but closing all these windows is getting irritating, any way to turn this off.

andy-portmen commented 7 years ago

So the extension works normally and you still get this page? It should only appear if there is no native client or when the external application exited with an unsuccessful code.

What is the extension name you are using and what are the arguments in the options page?

Inginn commented 7 years ago

yes the program works fine allways, just allways pops upp the "one last step" page settings:

display name: MPV Executable name: C:\Program Files\mpv\mpv.exe Arguments [HREF]

toolbar button: off Contextmenu: on on linked context

no icon file chosen

win 10, mpv compiled by lachs0r for windows, youtube-dl is used to stream youtube content. all versions up to date.

andy-portmen commented 7 years ago

I am not able to reproduce screen.zip

Chuunie commented 7 years ago

Hi. I too am having this issue. Pretty much exactly the same setup as Inginn. To be more specific this occurs when the video in MPV has finished playing and MPV closes itself or when MPV is closed manually. It also does not occur every time, it appears to occur randomly, but frequently enough that it is a little bit of a nuisance. Let me know if you would like a screen recording.

andy-portmen commented 7 years ago

Go to the extension manager and turn the develop mode on. Now open the "background page" beneath the extension. When the "Open Last Step" page opens, there should be an error appearing on this page. If so let me know the error.

Chuunie commented 7 years ago

I don't see an error showing up in the console on that page after it occurs.

Chuunie commented 7 years ago

After trying to make it occur on purpose I notice the video needs to be open for a while or playing for a while for it to happen as I haven't seen it happen on videos I open and close within a few seconds while I've been testing just now, although that could be a coincidence.

andy-portmen commented 7 years ago

If you have a sample that causes this, please share the link. What extension are you using? External Application Button or Open in MPV?

Chuunie commented 7 years ago

I am using External Application Button on the latest stable version of Vivaldi on Windows 10. I've seen this occur on various youtube videos and I think twitch VODs too. For the sake of testing, just now I chose this video from my youtube feed. I right clicked it in my feed and opened it with MPV from my context menu, I then watched it all the way through and allowed MPV to automatically close itself, upon closing itself the "One last step" tab opened in my browser.

andy-portmen commented 7 years ago

okay then, there will be a new option for each application to ignore application level errors. When the new version is released, update the entry for MPV and check "Ignore Errors" option.