search

andy-portmen / native-client

Native Messaging component for Windows, Linux, and Mac OS that is written in NodeJS.
https://add0n.com/open-in.html
Mozilla Public License 2.0
727 stars 474 forks source link

Open in VLC - Native client does not exit #32

Closed zoidy closed 7 years ago

zoidy commented 7 years ago

On Chromium. The addon successfully launches the native client but when VLC is closed, the native client does not. Opening more videos launches more native client instances that take up resources until the browser is closed.

andy-portmen commented 7 years ago

In what OS? So if I have no open instance of VLC and use the extension to send a link to VLC it is not working?

Opening more videos launches more native client instances

They are supposed to call the VLC executable and then exit.

zoidy commented 7 years ago

Guess I should have been more specific from the get go. Sorry about that. OS is Windows 10. Opening the link in VLC works. The problem is that closing VLC doesn't close node.exe

Steps:

  1. No VLC is currently running.
  2. open a video by right clicking and clicking Open in VLC
  3. Video opens and plays correctly. 2017-09-08_23-51-07
  4. Close VLC
  5. VLC closes but node.exe remains. strokesplus_2017-09-08_23-51-25

I manually specified the VLC path in the plugin.

andy-portmen commented 7 years ago

Thanks for the report. Please wait for the update and recheck. It should be fixed.