andy-portmen / open-in-vlc

a browser extension to send media links to VLC media player
https://webextension.org/listing/open-in-vlc.html
Mozilla Public License 2.0
113 stars 54 forks source link

[Request] Please make similar Chrome extension for MPC-HC #30

Closed bibsp closed 2 years ago

bibsp commented 2 years ago

Actually I found similar extension like yours, but that is not maintained anymore. https://chrome.google.com/webstore/detail/send-to-vlc-videolan-medi/hfckgfbhdacemicpjljhfbjmkiggeche https://github.com/belaviyo/send-to-vlc

In this extension if I change application path (like: "C:\Program Files\MPC-HC\mpc-hc64.exe") in option it actually works for other players. But in your extension if I do the same it doesn't work for other players.

So my request is to take code from that project (https://github.com/belaviyo/send-to-vlc) and make a separate extension for MPC-HC. It will be like Open in MPC-HC. Please sir...

andy-portmen commented 2 years ago

I just checked the extension with a custom application, and it works as expected. Double-check the executable path and retry.

What are your browser and OS?

bibsp commented 2 years ago

Chrome Windows 10 21h2

I just checked the extension with a custom application

Which extension? Yours? Or belaviyo's?

andy-portmen commented 2 years ago

Which extension?

Mine

bibsp commented 2 years ago

No that's not working. Even though it works, it is not my request to you.

https://addons.opera.com/en/extensions/details/send-to-media-player-classic-mpc-hc/ I'm requesting for this kind of thing for chrome.

Don't know why that person removed his extension for other players from chrome web store. But they are available on Firefox and Opera.

Please make a chrome extension named Open in MPC like him.

bibsp commented 2 years ago

Mine

Yes it is working with MPC "C:\Program Files\MPC-HC\mpc-hc64.exe" - Doesn't work C:\Program Files\MPC-HC\mpc-hc64.exe - Works

Inverted commas were culprits.

So almost everything is working. Only need to change the name to Open in MPC, Logo, and default path to C:\Program Files\MPC-HC\mpc-hc64.exe.

And fix one bug. Right click menu not working. Sample: https://anonfiles.com/9ew8C8O8xd/2022-03-16_17-33-58_Trim_mp4 This is not MPC bug. The problem is not there in belaviyo's send to vlc.

andy-portmen commented 2 years ago

It is very unlikely that I submit and maintain a new extension. There are many video players out there, and we cannot support all of them. You can download the GT project to a local directory and edit the title in the manifest.json file. For icons, replace the ones in the data/icons directory. That's it.

andy-portmen commented 2 years ago

And fix one bug. Right click menu not working.

For the right-click to appear, the link need to have a valid extension .mp4 instead of _mp4

bibsp commented 2 years ago

It is very unlikely that I submit and maintain a new extension. There are many video players out there, and we cannot support all of them. You can download the GT project to a local directory and edit the title in the manifest.json file. For icons, replace the ones in the data/icons directory. That's it.

I don't know how to do those things. 😥 But I'm sure that it is not a big headache for you to create another extension, because everything is already implemented.

Still if You really don't want to make different extensions for different players, You can do one thing. Rename your current extension to Open in External Player. Use a generic icon instead of VLC, MPC icons. No need of different icons basically. Set default path to vlc, so vlc users will not face any problem after update. Other people will set application path as per their need.

This looks so odd that I'm clicking on open in vlc, and it is launching a different player.

bibsp commented 2 years ago

For the right-click to appear, the link need to have a valid extension .mp4 instead of _mp4

You can fix this in your code. Because belaviyo's one works well in right click menu. Code can be copied from there.