andy-sweet / napari-metadata

A napari plugin to view and edit metadata
BSD 3-Clause "New" or "Revised" License
10 stars 3 forks source link

Add a reader contribution that supports ome-zarr #19

Closed andy-sweet closed 1 year ago

andy-sweet commented 1 year ago

This adds a reader contribution that vendors the reader from napari-ome-zarr and makes some modifications to it so that the extra-napari metadata support this plugin enables (e.g. axes) can be read from the ome-zarr directory. It also fixes some potential bugs in napari-ome-zarr I found while writing tests.

I also fixed some integration bugs found while doing an edit-write-read loop. I'm sure there are more to find and fix, but this gets a few of them.

codecov-commenter commented 1 year ago

Codecov Report

Merging #19 (a708f11) into main (65cc0ee) will decrease coverage by 2.35%. The diff coverage is 85.54%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   93.64%   91.30%   -2.35%     
==========================================
  Files          13       15       +2     
  Lines         834     1150     +316     
==========================================
+ Hits          781     1050     +269     
- Misses         53      100      +47     
Impacted Files Coverage Δ
src/napari_metadata/_reader.py 65.87% <65.87%> (ø)
src/napari_metadata/_model.py 87.50% <85.00%> (+0.98%) :arrow_up:
src/napari_metadata/_axis_type.py 94.11% <85.71%> (-5.89%) :arrow_down:
src/napari_metadata/_spatial_units_combo_box.py 92.10% <85.71%> (-1.65%) :arrow_down:
src/napari_metadata/_widget.py 91.17% <85.71%> (-1.14%) :arrow_down:
src/napari_metadata/_axes_name_type_widget.py 97.93% <100.00%> (+1.73%) :arrow_up:
src/napari_metadata/_axes_spacing_widget.py 97.61% <100.00%> (ø)
src/napari_metadata/_tests/test_reader.py 100.00% <100.00%> (ø)
src/napari_metadata/_tests/test_widget.py 99.58% <100.00%> (+0.07%) :arrow_up:
src/napari_metadata/_tests/test_writer.py 99.11% <100.00%> (+0.02%) :arrow_up:
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.