andy-sweet / napari-metadata

A napari plugin to view and edit metadata
BSD 3-Clause "New" or "Revised" License
10 stars 3 forks source link

Simplify plugin data model #33

Closed andy-sweet closed 1 year ago

andy-sweet commented 1 year ago

This change simplifies the plugin's data model module by reducing the number of functions. It also refactors some shared code between the widgets, though there is still plenty of repetition.

Closes #32

codecov-commenter commented 1 year ago

Codecov Report

Merging #33 (30121da) into main (6f5ceae) will increase coverage by 0.85%. The diff coverage is 98.61%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   92.87%   93.72%   +0.85%     
==========================================
  Files          16       16              
  Lines        1445     1371      -74     
==========================================
- Hits         1342     1285      -57     
+ Misses        103       86      -17     
Impacted Files Coverage Δ
src/napari_metadata/_widget.py 94.65% <95.45%> (+1.56%) :arrow_up:
src/napari_metadata/_axes_name_type_widget.py 98.42% <100.00%> (+2.97%) :arrow_up:
src/napari_metadata/_axes_spacing_widget.py 98.49% <100.00%> (-0.20%) :arrow_down:
src/napari_metadata/_model.py 94.87% <100.00%> (+5.68%) :arrow_up:
src/napari_metadata/_reader.py 72.38% <100.00%> (+0.20%) :arrow_up:
src/napari_metadata/_spatial_units_combo_box.py 91.89% <100.00%> (-0.22%) :arrow_down:
src/napari_metadata/_tests/test_widget.py 99.61% <100.00%> (ø)
src/napari_metadata/_widget_utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.