andy-sweet / napari-metadata

A napari plugin to view and edit metadata
BSD 3-Clause "New" or "Revised" License
10 stars 3 forks source link

Use compact double line edit instead of spin box #55

Closed andy-sweet closed 1 year ago

andy-sweet commented 1 year ago

This uses a custom line edit that mostly behaves like a double spinbox, except that it does not round the current value to a specific number of decimals. This makes for less frustrating interaction when specifying certain values and also makes things more compact by default. We do lose the interactivity of the spin box (which could be added back with some effort), but this widget is about metadata, not about manual alignment when that might be more relevant.

I also simplified some module and class names.

codecov-commenter commented 1 year ago

Codecov Report

Merging #55 (492118d) into main (ca369f3) will decrease coverage by 0.28%. The diff coverage is 91.86%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   93.50%   93.22%   -0.28%     
==========================================
  Files          16       16              
  Lines        1463     1506      +43     
==========================================
+ Hits         1368     1404      +36     
- Misses         95      102       +7     
Impacted Files Coverage Δ
src/napari_metadata/_widget_utils.py 88.15% <86.53%> (-4.44%) :arrow_down:
src/napari_metadata/_axes_widget.py 98.33% <100.00%> (ø)
src/napari_metadata/_tests/test_widget.py 99.63% <100.00%> (ø)
src/napari_metadata/_transform_widget.py 98.52% <100.00%> (ø)
src/napari_metadata/_widget.py 93.26% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.