search

andy-thomason / Vookoo

A set of utilities for taking the pain out of Vulkan in header only modern C++
MIT License
521 stars 52 forks source link

Should it be Break here? vku_framework.hpp:init function #11

Closed zhenqinshang closed 5 years ago

zhenqinshang commented 5 years ago

for (uint32t qi = 0; qi != qprops.size(); ++qi) { auto &qprop = qprops[qi]; VkBool32 presentSupport = false; if (pd.getSurfaceSupportKHR(qi, surface)) { presentQueueFamily_ = qi; found = true; break;//here add break } }

andy-thomason commented 5 years ago

It could indeed. I think the logic used to be more complex which precluded the break. It would only save a microsecond or so from startup time. I'll look at this.

zhenqinshang commented 5 years ago

Thanks. Closed.