search

andy-thomason / Vookoo

A set of utilities for taking the pain out of Vulkan in header only modern C++
MIT License
522 stars 52 forks source link

Return type mismatch in [Compute]PipelineMaker #48

Closed tomix1024 closed 2 years ago

tomix1024 commented 2 years ago

I came across this library today and it seems to be quite promising. With the current version of the Vulkan-Hpp headers, the return type of vku::PipelineMaker::createUnique and vk::Device::createGraphicsPipelineUnique mismatches.

I'd suggest to change the return value of (all) those functions to auto in order to avoid future incompatibilities between the APIs.

tomix1024 commented 2 years ago

At second thought, I think it would be better if the return type was unchanged. and the ePipelineCompileRequiredEXT that is indicated via the vk::Result return type should be mapped to an additional, optional parameter of vku::PipelineMaker::createUnique...