andy-thomason / Vookoo

A set of utilities for taking the pain out of Vulkan in header only modern C++
MIT License
522 stars 52 forks source link

fix uninitialized variable #7

Closed TinyTinni closed 5 years ago

TinyTinni commented 6 years ago

If the constructor (init function), an object will be created but ok_ is not guaranteed to be false. This leads that i.e. the window::ok() method may give a non correct output.

Btw: Is there a reason, why you are using a init method instead of constructor delegation for the window class? If not, I may rewrite the constructors in such a way, that the initializer expression can be used (which removes a potential unnecessary init of some objects).