search

andy-thomason / Vookoo

A set of utilities for taking the pain out of Vulkan in header only modern C++
MIT License
521 stars 52 forks source link

using Vulkan-Hpp update to 1.1.85 miss vk::SurfaceKHRDeleter change #9

Closed paolobia closed 5 years ago

paolobia commented 5 years ago

I use Vulkan-Hpp update to 1.1.85 in vkuframework.hpp at 294 I have change from `surface = vk::UniqueSurfaceKHR(surface, vk::SurfaceKHRDeleter{ instance });); to surface_ = vk::UniqueSurfaceKHR(surface, vk::ObjectDestroy<vk::Instance, vk::DispatchLoaderStatic>(instance));`

otherwise, erasing the surface_ will cause a crash

andy-thomason commented 5 years ago

Thanks for the update. I noticed the surface issue. Your solution is probably better than mine (making the surface a non-deleting object).

I'm not used to having people so attentive to updates!

Andy.

andy-thomason commented 5 years ago

If you would prefer your change, reopen this issue.