search

andybalaam / rabbit-escape

Android and PC game inspired by Lemmings and Pingus
http://artificialworlds.net/rabbit-escape
GNU General Public License v2.0
75 stars 40 forks source link

Fix "DontStepAfterFinish" crash #517

Open andybalaam opened 6 years ago

andybalaam commented 6 years ago

This crash was reported through the App store:

app version 102
Samsung Galaxy S5 mini, 1536MB RAM, Android 4.4
Report 1 of 1
rabbitescape.engine.World$DontStepAfterFinish: 
  at rabbitescape.engine.World.step (World.java:251)
  at rabbitescape.render.gameloop.GeneralPhysics$WorldModifier.step (GeneralPhysics.java:40)
  at rabbitescape.render.gameloop.GeneralPhysics.step (GeneralPhysics.java:135)
  at rabbitescape.render.gameloop.GameLoop.step (GameLoop.java:69)
  at rabbitescape.render.gameloop.GameLoop.run (GameLoop.java:51)
  at rabbitescape.ui.android.AndroidGameLaunch.run (AndroidGameLaunch.java:83)
  at java.lang.Thread.run (Thread.java:841)

Figure out how this could have been triggered in normal play, and prevent it from happening, or handle it more gracefully if we have to.

tttppp commented 6 years ago

Do you know what version 102 corresponds to in terms of tags? Does it include rabbots?

tttppp commented 6 years ago

Is it version 0.10.2?

andybalaam commented 6 years ago

Yes, it is 0.10.2 (sorry for slow reply)

andybalaam commented 6 years ago

https://github.com/andybalaam/rabbit-escape/blob/master/rabbit-escape-ui-android/app/build.gradle - versionCode and versionName

andybalaam commented 5 years ago

Another example in version 0.13 on a Samsung Galaxy S7:

rabbitescape.engine.World$DontStepAfterFinish: 
  at rabbitescape.engine.World.step (World.java:307)
  at rabbitescape.render.gameloop.GeneralPhysics$WorldModifier.step (GeneralPhysics.java:43)
  at rabbitescape.render.gameloop.GeneralPhysics.step (GeneralPhysics.java:147)
  at rabbitescape.render.gameloop.GameLoop.step (GameLoop.java:76)
  at rabbitescape.render.gameloop.GameLoop.run (GameLoop.java:58)
  at rabbitescape.ui.android.AndroidGameLaunch.run (AndroidGameLaunch.java:83) 
  at java.lang.Thread.run (Thread.java:764)